Add an optional timeout to dmypy_server #4700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvanrossum
reviewed
Mar 8, 2018
mypy/dmypy_server.py
Outdated
| @@ -159,12 +168,15 @@ def serve(self) -> None: | |||
| if command == 'stop': | |||
| sock.close() | |||
| sys.exit(0) | |||
| except socket.timeout: | |||
There was a problem hiding this comment.
Maybe this try/except should only wrap the accept() call?
fba8c4c to
b328f74
Compare
This allows it ot shut down after a period of inactivity to avoid hogging memory. Also don't crash the server on an error communicating with the client.
773f41b to
22456ff
Compare
gvanrossum
approved these changes
Mar 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows it to shut down after a period of inactivity to avoid
hogging memory.
Also don't crash the server on an error communicating with the client.