Don't produce spurious unused type ignore messages in incremental mode #4841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
This is accomplished by generating diagnostics for suppressed dependencies before generating unused ignore notes. This requires that we store line information for suppressed dependencies in our cache files. Fixes #2960
gvanrossum
approved these changes
Apr 4, 2018
mypy/build.py
Outdated
|
|
||
| def generate_unused_ignore_notes(self) -> None: | ||
| if self.options.warn_unused_ignores: | ||
| # If this file was initially loaded from the cache, it may have suppressed | ||
| # dependencies due to imports with ignores on them. We need to generate | ||
| # those errors to avoid spuriously them as unused ignores. |
There was a problem hiding this comment.
missing word "flagging" after "spuriously".
JukkaL
reviewed
Apr 4, 2018
There was a problem hiding this comment.
Looks reasonable, but it would be good if @gvanrossum would also have a look at this since my context is lacking here.
mypy/build.py
Outdated
| @@ -1909,14 +1912,18 @@ def write_cache(self) -> None: | |||
| self.mark_interface_stale() | |||
| self.interface_hash = new_interface_hash | |||
|
|
|||
| def verify_dependencies(self) -> None: | |||
| def verify_dependencies(self, suppressed_only: bool=False) -> None: | |||
There was a problem hiding this comment.
Document the suppressed_only argument.
Style nit: Add spaces around = in bool=False.
| @@ -4206,3 +4206,14 @@ class Two: | |||
| pass | |||
| [out2] | |||
| tmp/m/two.py:2: error: Revealed type is 'builtins.str' | |||
|
|
|||
| [case testImportUnusedIgnore] | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is accomplished by generating diagnostics for suppressed
dependencies before generating unused ignore notes. This requires
that we store line information for suppressed dependencies in our
cache files.
Fixes #2960.