Store MROs in cache files instead of recomputing them #4921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a prerequisite for loading .data.json files on demand (#4910), since if MROs are computed on-demand when a tree is loaded, it is impossible to detect changes in the MRO caused by a change in some other file that triggered an on-demand load.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a prerequisite for loading .data.json files on demand (#4910),
since if MROs are computed on-demand when a tree is loaded, it is
impossible to detect changes in the MRO caused by a change in some
other file that triggered an on-demand load.
This has been split out of #4910 for staging reasons: landing the parts
the modify the cache formats will make it easier to do testing with real-world
commits on the rest of #4910 (which is higher risk).