Fix mypyc breakage caused by mypy multiple inheritance bug #6480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug #3603 strikes again. We've got this workaround in another place or two.
gvanrossum
approved these changes
Feb 25, 2019
gvanrossum
approved these changes
Feb 25, 2019
msullivan
added a commit
that referenced
this pull request
Feb 25, 2019
…sues A mypy bug (#3603) causes mypy to think that SymbolNodes cannot be FuncBases, which causes mypy-mypyc to crash in code that tests that. Currently we work around this in a couple gross ways (like turning the SymbolNode into Any). Work around it instead by testing directly against a tuple of the subtypes instead of FuncBase itself. This is the better fix promised in #6480.
msullivan
added a commit
that referenced
this pull request
Feb 28, 2019
#6481) A mypy bug (#3603) causes mypy to think that SymbolNodes cannot be FuncBases, which causes mypy-mypyc to crash in code that tests that. Currently we work around this in a couple gross ways (like turning the SymbolNode into Any). Work around it instead by testing directly against a tuple of the subtypes instead of FuncBase itself. This is the better fix promised in #6480.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug #3603 strikes again. We've got this workaround in another place or
two.
I have a plan for a less bad workaround involving introducing a
SymbolNodeFuncDefclass, but let's stop the bleeding first.