Add --no-implicit-reexport flag #6562
Conversation
|
There may be poor behavior if this is enabled without |
There was a problem hiding this comment.
- Remove
nofrom the option name and revert the default (but keep--noprefix in flag) - Add docs (for both flag and option)
- Update the comments (they only refer to stubs)
- Can you come up with an example of the poor interaction when
ignore_missing_importsis not enabled?
|
I've thought about it some and the interactions with ignore_missing_imports seems fine? Ignore missing imports ignores missing modules, not missing attributes. I'm going to try to get mypy to check clean with this option and report back on that. |
This makes mypy check clean with the proposed --no-implicit-reexports flag from PR #6562. Some of the implicit reexports that were depended on were clearly intended (type_visitor) and so made explicit, while some were clearly unintended (Optional from mypy.types!) and fixed. Probably worth landing this whichever way we decide on #6562, but I think this PR is an argument in favor.
|
#6570 fixes mypy to check clean with this. The error output was intimidating at first (because of all the knock-on effects), but when I just looked at the import failures it was very simple to tackle. (It may be a good idea to treat imports of non-public names differently: produce an error on the import, but still resolve the name to the private symbol, to reduce the error volume and to provide better type checking if the import error gets ignored. That's neither here nor there for this bug.) |
This makes mypy check clean with the proposed --no-implicit-reexports flag from PR #6562. Some of the implicit reexports that were depended on were clearly intended (type_visitor) and so made explicit, while some were clearly unintended (Optional from mypy.types!) and fixed. Probably worth landing this whichever way we decide on #6562, but I think this PR is an argument in favor.
bafecfe to
d61833f
Compare
test-data/unit/check-flags.test
Outdated
| [case testNoImplicitReexport] | ||
| # flags: --no-implicit-reexport | ||
| from other_module_2 import a | ||
|
|
There was a problem hiding this comment.
I'd remove all the blank lines from the test cases except the blank line between test cases (so no blank lines between files within a test case).
docs/source/config_file.rst
Outdated
| # This won't re-export the value | ||
| from foo import bar | ||
| # This will re-export it as bar and allow other modules to import it | ||
| from foo import bar as bar |
There was a problem hiding this comment.
Indentation is still wrong here.
Adds a --no-implicit-reexport flag, intended for giving modules the same behavior as stubs for re-exporting their imports. The goal is to make it possible to prevent bad transitive imports from causing dependency issues. And to make it easier to move things to a different module.
Adds a --no-implicit-reexport flag, intended for giving modules the same behavior as stubs for re-exporting their imports.
The goal is to make it possible to prevent bad transitive imports from causing dependency issues. And to make it easier to move things to a different module.