Skip to content

Apply --strict-equality special-casing for bytes and bytearray on Python 2 #7493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 10, 2019
Merged

Apply --strict-equality special-casing for bytes and bytearray on Python 2 #7493

merged 2 commits into from
Sep 10, 2019

Conversation

ilevkivskyi
Copy link
Member

Fixes #7465

The previous fix only worked on Python 3.

JukkaL
JukkaL approved these changes Sep 10, 2019
View reviewed changes
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the false positive!

@ilevkivskyi ilevkivskyi merged commit 226a4f1 into python:master Sep 10, 2019
@ilevkivskyi ilevkivskyi deleted the fix-py2-byearray branch September 10, 2019 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JukkaL JukkaL JukkaL approved these changes

@msullivan msullivan Awaiting requested review from msullivan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bytes in bytearray containment wrongly flagged by strict equality
2 participants
@ilevkivskyi @JukkaL