mypy: remove subprocess samples #8838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They depend heavily on _subprocess, which is no longer a module that exists: python/typeshed#4022 (comment)
|
Seems like we should add in some newer samples. Current subprocess.py and test_subprocess.py don't type check off the bat, but I can twist them until they do |
|
I'm not sure that's necessary. I think these samples were added as a way to run mypy on a largish codebase when the project was getting started, but now mypy is run on huge codebases that are more useful to find regressions (like Dropbox's codebases). @JukkaL what do you think? |
|
I don't think that the stdlib samples are very useful any more. We can keep those that can be maintained without much effort, but non-trivial investments into them don't seem worth it. |
JukkaL
approved these changes
May 18, 2020
hauntsaninja
pushed a commit
to hauntsaninja/mypy
that referenced
this pull request
Aug 29, 2020
This is no longer valid code on Python 3.9, so py39 CI fails. We've talked about not investing in keeping these samples up to date: python#8838 (comment)
hauntsaninja
added a commit
that referenced
this pull request
Aug 30, 2020
This is no longer valid code on Python 3.9, so py39 CI fails. We've talked about not investing in keeping these samples up to date: #8838 (comment) Co-authored-by: hauntsaninja <>
hauntsaninja
pushed a commit
to hauntsaninja/mypy
that referenced
this pull request
Jan 5, 2022
I don't know that these have caught any real issues in the last couple years, however, the standard library ones have been a bit of a pain, most recently in python#11905. Jukka was okay removing the stdlib samples two years ago, see python#8838 (comment) We now have tooling like mypy primer that runs mypy over a much larger and more varied corpus of code on every PR. The other samples haven't caused me much bother, but except for crawl2, they're all very simple. I don't think they provide us much value, unless they have sentimental or historical value.
Merged
hauntsaninja
added a commit
that referenced
this pull request
Jan 8, 2022
I don't know that these have caught any real issues in the last couple years, however, the standard library ones have been a bit of a pain, most recently in #11905. Jukka was okay removing the stdlib samples two years ago, see #8838 (comment) We now have tooling like mypy primer that runs mypy over a much larger and more varied corpus of code on every PR. The other samples haven't caused me much bother (except for crawl, which I removed in #9375), but except for crawl2, they're all very simple. I don't think they provide us much value, unless they have sentimental or historical value.
tushar-deepsource
pushed a commit
to DeepSourceCorp/mypy
that referenced
this pull request
Jan 20, 2022
I don't know that these have caught any real issues in the last couple years, however, the standard library ones have been a bit of a pain, most recently in python#11905. Jukka was okay removing the stdlib samples two years ago, see python#8838 (comment) We now have tooling like mypy primer that runs mypy over a much larger and more varied corpus of code on every PR. The other samples haven't caused me much bother (except for crawl, which I removed in python#9375), but except for crawl2, they're all very simple. I don't think they provide us much value, unless they have sentimental or historical value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They depend heavily on _subprocess, which is no longer a module that
exists: python/typeshed#4022 (comment)