Skip to content

Change test to platform check for windows-specific type checking #8916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2020
Merged

Change test to platform check for windows-specific type checking #8916

merged 1 commit into from
May 29, 2020

Conversation

CraftSpider
Copy link
Contributor

This test currently fails on python/typeshed#4137 due to mypy not recognizing the existing check as meaning the block is windows-specific, so it claims that getwindowsversion doesn't exist.

@CraftSpider CraftSpider mentioned this pull request May 28, 2020
Merged
@JelleZijlstra JelleZijlstra self-assigned this May 28, 2020
@JelleZijlstra JelleZijlstra merged commit 273a865 into python:master May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees

@JelleZijlstra JelleZijlstra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CraftSpider @JelleZijlstra