[mypyc] Use C optimization level 0 for tests by default #9131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This speeds up run tests significantly, but it might miss some checks
only performed on higher optimization levels.
On my Linux desktop, this speeds up `pytest mypyc` from about 18s to
about 12s. It should also speed up CI builds, but I haven't measured
the impact.
Let's try this out. We can always revert this back if this turns out
to cause problems.
The environment variable MYPYC_OPT_LEVEL can be used to override
the optimization level. Example:
MYPYC_OPT_LEVEL=3 pytest mypyc
Closes mypyc/mypyc#745.
|
Maybe I should finish #9030 quickly... so we can make opt_level a -O{0-3} option |
|
There's no hurry, since we'll need a different way to pass options to pytest anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This speeds up run tests significantly, but it might miss some checks
only performed on higher optimization levels.
On my Linux desktop, this speeds up
pytest mypycfrom about 18s toabout 12s. It should also speed up CI builds, but I haven't measured
the impact.
Let's try this out. We can always revert this back if this turns out
to cause problems.
The environment variable MYPYC_OPT_LEVEL can be used to override
the optimization level. Example:
Closes mypyc/mypyc#745.