PEP 484: only reexport for X as X forms #9515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 30, 2020 21:35
See recent discussion on typing-sig leading to a PEP 484 amendment.
JelleZijlstra
approved these changes
Oct 4, 2020
hauntsaninja
added a commit
to hauntsaninja/mypy
that referenced
this pull request
Oct 4, 2020
See recent discussion on typing-sig leading to a PEP 484 amendment. Co-authored-by: hauntsaninja <>
osandov
added a commit
to osandov/drgn
that referenced
this pull request
Jan 22, 2021
mypy 0.800 is stricter about reexports: "from foo import X as Y" is only considered a reexport if X and Y are the same name (see python/mypy#9515). mypy 0.800 fails with: drgn/internal/cli.py:46: error: Module has no attribute "__version__" Rename drgn.internal.version.version to __version__ so that drgn/__init__.py can reexport it with import __version__ as __version__. Signed-off-by: Omar Sandoval <osandov@osandov.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See recent discussion on typing-sig leading to a PEP 484 amendment.