[stubgenc] Render a bit better stubs #9903
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
61fb40c to
1a42e68
Compare
JukkaL
reviewed
Jan 15, 2021
Functions may depend on class definitions, therefore should go after classes to not confuse some static analysis tools. A better solution (although way complex) would be a topological sort of all module elements (including variables)
…) signature Overloaded function header in pybind11 was erroneously recognized as an extra overload.
Pybind includes function name in the property signature in docstrings
1a42e68 to
951fc37
Compare
22 tasks
This comment has been minimized.
This comment has been minimized.
1 similar comment
|
Gentle ping |
|
Is this PR too big? Should it be split into smaller pieces, which can be easily reviewed? The individual changes are rather small and related, but are decoupled to some degree, so they can be applied one after another if needed. I thought it would be faster to ship them as one, rather than a series of dependent PRs. Please let me know if I can do anything to push the changes forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR contains a couple of improvements of stubgenc generator:
(*args, **kwargs)overloads in pybind11 modules (closes Ignore generic type signature in pybind11 functions and methods with overloads #9070)x: ClassVar[T]x: T)Test Plan
Tests against
pybind11-mypy-demoproject are included