Skip to content

"created from a pull request" banner loses position when closed #3657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gvanrossum opened this issue Feb 9, 2024 · 2 comments
Closed

"created from a pull request" banner loses position when closed #3657

gvanrossum opened this issue Feb 9, 2024 · 2 comments
Labels
bug infra Core infrastructure for building and rendering PEPs

Comments

@gvanrossum
Copy link
Member

gvanrossum commented Feb 9, 2024

If you go here:

https://pep-previews--3649.org.readthedocs.build/pep-0742/#type-narrowing-behavior

You are taken to the desired page and anchor, but a banner is displayed with the text

This page was created from a pull request build

See the build's detail page or pull request readthedocs/readthedocs.org#3649 for more information.

That banner is helpful, but it is also in the way, so there's a little 'x' in the top right corner to click it away. However, when I click that 'x', the URL is somehow rewritten so the anchor is lost (leaving https://pep-previews--3649.org.readthedocs.build/pep-0742/#), which is not helpful.

I'm assuming this is a simple html/css/js error in the template for the banner?

(As a workaround, you can hit "Back" to go to the anchor, but that's unintuitive, and it definitely smells like a bug. :-)

@hugovk
Copy link
Member

hugovk commented Feb 9, 2024

I've reported this at RTD at readthedocs/addons#246

@python python deleted a comment from karimahmadi99 Feb 19, 2024
@hugovk
Copy link
Member

hugovk commented Feb 20, 2024

This has now been fixed and deployed by the Read the Docs team. 🚀

@hugovk hugovk closed this as completed Feb 20, 2024
@CAM-Gerlach CAM-Gerlach added bug infra Core infrastructure for building and rendering PEPs labels Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug infra Core infrastructure for building and rendering PEPs
Projects
None yet
Development

No branches or pull requests

3 participants