-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Change language from BDFL-Delegate to PEP-Delegate #1672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
If it matters, I'm fine with changing it. I haven't looked at this PR
though.
|
I haven't either, but I'm -0 on changing existing PEPs. I don't see much value in changing this header for closed PEPs, and I would leave it to PEP authors to update their own active PEPs if they want. That said, I think we should update PEP 1 to use the term |
So the pep tooling will need to recognize both headers? And have a list of
PEPs that are allowed to have the old header? That seems complicated.
|
The former, but not the latter. We already have enough process and policy around discouraging changing closed PEPs. |
I'm fine with leaving old PEPs but updating PEP 1 and 12 to use the newer name. |
So if someone uses BDFL-Delegate in a new PEP it's up to manual code review
to point out the mistake. Oh, okay.
|
@hugovk Would you like to amend this PR to do as @brettcannon suggests? Or close this one and create a new PR with just those changes? |
Yep, will amend this one. |
Updated! Kept the changes in PEP 1 and 12, and update the generation scripts to handle PEP-Delegate in addition to BDFL-delegate. Is |
I don't know, but lots of signs point to "no", given how long ago that file was touched last, the not only Python 2'isms in the file but
Maybe @brettcannon knows? OTOH, debugging-by-breaking is often a great technique :D -- maybe delete it and we can see if anything breaks? |
Co-authored-by: Brett Cannon <brett@python.org>
Co-authored-by: Brett Cannon <brett@python.org>
I have no clue about whether |
Fixes #1431.
The first commit updates the header fields from BDFL-Delegate to PEP-Delegate.
The second updates other uses in PEPs. I left a couple in I thought should stay (one in a post history, another being contrasted with PEP Delegate).
And also added a bit to the PEP 1 paragraph that gives the BDFL background:
And the last commit updates generation scripts.