Skip to content

Change language from BDFL-Delegate to PEP-Delegate #1672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 26, 2020

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Oct 22, 2020

Fixes #1431.

The first commit updates the header fields from BDFL-Delegate to PEP-Delegate.

The second updates other uses in PEPs. I left a couple in I thought should stay (one in a post history, another being contrasted with PEP Delegate).

And also added a bit to the PEP 1 paragraph that gives the BDFL background:

-This PEP still uses the title "BDFL-Delegate" for PEP decision makers. This was
+This PEP earlier used the title "BDFL-Delegate" for PEP decision makers. This was
a historical reference to Python's previous governance model, where all design
authority ultimately derived from Guido van Rossum, the original creator of the
Python programming language. By contrast, the Steering Council's design
authority derives from their election by the currently active core developers.
+Now, PEP-Delegate is used in place of BDFL-Delegate.

And the last commit updates generation scripts.

@gvanrossum
Copy link
Member

gvanrossum commented Oct 23, 2020 via email

@warsaw
Copy link
Member

warsaw commented Oct 23, 2020

I haven't either, but I'm -0 on changing existing PEPs. I don't see much value in changing this header for closed PEPs, and I would leave it to PEP authors to update their own active PEPs if they want.

That said, I think we should update PEP 1 to use the term PEP-Delegate, enforce that term in new PEPs, and encourage (but not force) active PEP authors to update their own PEPs.

@gvanrossum
Copy link
Member

gvanrossum commented Oct 23, 2020 via email

@warsaw
Copy link
Member

warsaw commented Oct 23, 2020

So the pep tooling will need to recognize both headers? And have a list of PEPs that are allowed to have the old header?

The former, but not the latter. We already have enough process and policy around discouraging changing closed PEPs.

@brettcannon
Copy link
Member

I'm fine with leaving old PEPs but updating PEP 1 and 12 to use the newer name.

@gvanrossum
Copy link
Member

gvanrossum commented Oct 23, 2020 via email

@warsaw
Copy link
Member

warsaw commented Oct 23, 2020

@hugovk Would you like to amend this PR to do as @brettcannon suggests? Or close this one and create a new PR with just those changes?

@hugovk
Copy link
Member Author

hugovk commented Oct 23, 2020

Yep, will amend this one.

@hugovk
Copy link
Member Author

hugovk commented Oct 23, 2020

Updated!

Kept the changes in PEP 1 and 12, and update the generation scripts to handle PEP-Delegate in addition to BDFL-delegate.

Is pep2pyramid.py still needed or can it be deleted? It's not called by anything, has Python 2 prints, and references to it were removed from PEP 1 in #626.

@warsaw
Copy link
Member

warsaw commented Oct 23, 2020

Is pep2pyramid.py still needed or can it be deleted? It's not called by anything, has Python 2 prints, and references to it were removed from PEP 1 in #626.

I don't know, but lots of signs point to "no", given how long ago that file was touched last, the not only Python 2'isms in the file but

REQUIRES = {'python': '2.2',
            'docutils': '0.5'}

Maybe @brettcannon knows? OTOH, debugging-by-breaking is often a great technique :D -- maybe delete it and we can see if anything breaks?

warsaw and others added 2 commits October 23, 2020 14:12
Co-authored-by: Brett Cannon <brett@python.org>
Co-authored-by: Brett Cannon <brett@python.org>
@brettcannon
Copy link
Member

I have no clue about whether pep2pyramid.py is still used. I'm with Barry and we can try deleting it in a separate PR for easy rollback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change language from BDFL-Delegate to PEP-Delegate
5 participants