-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
PEP 594: Update Discussions-To link and date with posting of new thread #2335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEP 594: Update Discussions-To link and date with posting of new thread #2335
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I actually left that link alone so someone could follow the complete discussion from beginning to end, but it isn't worth holding the PR up over. |
Good point; in general it would seem to make sense to link the current/most recent active discussion, but I did check that you prominently linked the previous one in the OP of the current one (as you of course took care to do), so interested users can still follow it. It would be nice to inline-link each |
I think I disagree here -- 'discussions-to' should be where one can currently post observations, questions, etc, not previous discussions. If PEP authors want to preserve previous links I would advise a footnote or similar noting that discussion on a previous version of the PEP took place at . A |
I agreed 100% with this—what I was saying is if we could allow inline links in the |
Sorry if I misinterpreted you, glad we agree!
I'm maybe -0.5 on this, I think I'd need to be convinced some more, especially as some authors create new threads each time, some authors re-use the same thread, some authors post simultaneously to Discourse/Python-Dev/Typing-Sig/etc but may have a preference -- catering for all cases would be challenging. Anyway, we should stop hijacking this thread for that putative discussion! A |
Brett approved as a co-author above, merging now. A |
Agreed; mentioned and replied on #2266 |
A new discussion thread was opened for this PEP on Discourse following the last round of updates; this updates the PEP headers to reflect that.
First noticed by @hugovk in #2334