Skip to content

PEP 594: Update Discussions-To link and date with posting of new thread #2335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2022

Conversation

CAM-Gerlach
Copy link
Member

A new discussion thread was opened for this PEP on Discourse following the last round of updates; this updates the PEP headers to reflect that.

First noticed by @hugovk in #2334

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@brettcannon
Copy link
Member

I actually left that link alone so someone could follow the complete discussion from beginning to end, but it isn't worth holding the PR up over.

@CAM-Gerlach
Copy link
Member Author

CAM-Gerlach commented Feb 16, 2022

I actually left that link alone so someone could follow the complete discussion from beginning to end, but it isn't worth holding the PR up over.

Good point; in general it would seem to make sense to link the current/most recent active discussion, but I did check that you prominently linked the previous one in the OP of the current one (as you of course took care to do), so interested users can still follow it.

It would be nice to inline-link each Post-History date to the relevant thread, but we'd need to discuss that first since that would be a broader change in the header format.

@AA-Turner
Copy link
Member

It would be nice to inline-link each Post-History date to the relevant thread

I think I disagree here -- 'discussions-to' should be where one can currently post observations, questions, etc, not previous discussions. If PEP authors want to preserve previous links I would advise a footnote or similar noting that discussion on a previous version of the PEP took place at .

A

@CAM-Gerlach
Copy link
Member Author

I think I disagree here -- 'discussions-to' should be where one can currently post observations, questions, etc, not previous discussion

I agreed 100% with this—what I was saying is if we could allow inline links in the Post-History section, we could inline-link each post date with the relevant thread (mailing list, discouse, etc) which would track the history and be much more useful than just the date. But that's a subject for another issue, and might require changes to the header processing and rendering logic (which you'd likely be the best person to ask on that).

@AA-Turner
Copy link
Member

I agreed 100% with this

Sorry if I misinterpreted you, glad we agree!

allow inline links in the Post-History section ... inline-link each post date with the relevant thread

I'm maybe -0.5 on this, I think I'd need to be convinced some more, especially as some authors create new threads each time, some authors re-use the same thread, some authors post simultaneously to Discourse/Python-Dev/Typing-Sig/etc but may have a preference -- catering for all cases would be challenging.

Anyway, we should stop hijacking this thread for that putative discussion!

A

@AA-Turner
Copy link
Member

Brett approved as a co-author above, merging now.

A

@CAM-Gerlach
Copy link
Member Author

Anyway, we should stop hijacking this thread for that putative discussion!

Agreed; mentioned and replied on #2266

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants