Skip to content

PEP 655: Mark as accepted #2451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2022
Merged

PEP 655: Mark as accepted #2451

merged 1 commit into from
Mar 22, 2022

Conversation

JelleZijlstra
Copy link
Member

cc @davidfstr. Also, I opened https://bugs.python.org/issue47087 to track the CPython implementation, but couldn't find you there

cc @davidfstr. Also, I opened https://bugs.python.org/issue47087 to track the CPython implementation, but couldn't find you there
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

FYI, following standard GitHub flow and creating these branches in the fork rather than upstream will avoid running and displaying duplicate sets of checks (as well as cluttering the upstream branch list).

Type: Standards Track
Content-Type: text/x-rst
Created: 30-Jan-2021
Python-Version: 3.11
Post-History: 31-Jan-2021, 11-Feb-2021, 20-Feb-2021, 26-Feb-2021, 17-Jan-2022, 28-Jan-2022
Resolution: https://mail.python.org/archives/list/python-dev@python.org/message/AJEDNVC3FXM5QXNNW5CR4UCT4KI5XVUE/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi the typing-sig version is https://mail.python.org/archives/list/typing-sig@python.org/thread/AJEDNVC3FXM5QXNNW5CR4UCT4KI5XVUE/ - the emails on this one were caught in moderation so they didn't appear at the same time ;) as discussion was on typing-sig, maybe link to that one?

Copy link
Member

@CAM-Gerlach CAM-Gerlach Mar 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, but the the Typing-SIG thread is already linked in the Discussions-To header, and Python-Dev is the canonical place to post (non-Packaging, given its SC-delegated authority) PEP resolutions per PEP 1, as most recently discussed in #2266 , implemented in #2346 and approved by the SC in python/steering-council#113:

Except where otherwise approved by the Steering Council, pronouncements of PEP resolution will be posted to the Python-Dev mailing list.

@davidfstr
Copy link
Contributor

LGTM. 🥳

Now it's time to implement. @JelleZijlstra I did add myself as Nosy on the BPO item. I did look for a way to self-assign it since I'm guessing the implementation will fall to me but did not find a way.

@JelleZijlstra JelleZijlstra merged commit 3b879dd into main Mar 22, 2022
@JelleZijlstra JelleZijlstra deleted the JelleZijlstra-patch-1 branch March 22, 2022 15:49
@JelleZijlstra
Copy link
Member Author

@davidfstr it looks like BPO doesn't let me assign an issue to non-core devs, but please go ahead. If you don't have time I can help out with the implementation too; we just have to make sure it goes in before the feature freeze in about a month.

@davidfstr
Copy link
Contributor

we just have to make sure it goes in before the feature freeze in about a month.

I'm tracking this key date very carefully. ^_^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants