Skip to content

PEP 11: fix nit typo of my name #2538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2022
Merged

Conversation

corona10
Copy link
Member

No description provided.

@corona10 corona10 requested a review from vstinner April 19, 2022 08:18
@corona10 corona10 requested a review from brettcannon as a code owner April 19, 2022 08:18
@Rosuav
Copy link
Contributor

Rosuav commented Apr 19, 2022

Not sure what happened, but this also changed some other formatting. Possibly the line got wrapped when you edited it?

@corona10
Copy link
Member Author

@Rosuav Thanks, looks like my fat finger :)

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how to review such PR, but your name looks good to me :-)

@corona10
Copy link
Member Author

corona10 commented Apr 19, 2022

@brettcannon Don't we have to update Post-History: section for your supported-tier?

@Rosuav
Copy link
Contributor

Rosuav commented Apr 19, 2022

👍

@CAM-Gerlach CAM-Gerlach changed the title PEP 11: fix nit typo of my name. PEP 11: fix nit typo of my name Apr 19, 2022
@CAM-Gerlach
Copy link
Member

CAM-Gerlach commented Apr 19, 2022

@brettcannon Don't we have to update Post-History: section for your supported-tier?

If you posted it somewhere, you'd want to add the date and link of the thread, yeah, like this:

Post-History: ....,
              `DD-mmm-YYYY <https://link.to/thread>`__

and if there's a thread somewhere for further discussions, you should add it to Discussions-To. But if not, then you don't have to.

@brettcannon brettcannon merged commit 6879a7d into python:main Apr 19, 2022
@brettcannon
Copy link
Member

If you posted it somewhere

Depends on your definition of "posted". 😁 I posted a part of my proposed changes to python-committers, but never the full PEP or all the changes. It also got smeared across https://mail.python.org/archives/list/python-committers@python.org/thread/K757345KX6W5ZLTWYBUXOXQTJJTL7GW5/ and https://mail.python.org/archives/list/python-committers@python.org/thread/V3OZPJGA5VJFYM6XYGPZIVPOIYKX6KTD/ .

@JelleZijlstra
Copy link
Member

I think it would be helpful to add those links to the PEP, since you pretty much rewrote the whole thing, and in the future it would be useful to be able to refer back to those threads.

Also, maybe the PEP should be renamed to something like "Platform support policy".

@CAM-Gerlach
Copy link
Member

Depends on your definition of "posted". grin I posted a part of my proposed changes to python-committers, but never the full PEP or all the changes. It also got smeared across https://mail.python.org/archives/list/python-committers@python.org/thread/K757345KX6W5ZLTWYBUXOXQTJJTL7GW5/ and https://mail.python.org/archives/list/python-committers@python.org/thread/V3OZPJGA5VJFYM6XYGPZIVPOIYKX6KTD/ .

Its a rather loose definition 😃 and certainly doesn't encourage, much less require actually posting the full raw PEP text. So long as its a venue for PEP discussion that follows the basic criteria in PEP 1 (technically speaking, it isn't publicly postable, but for Post-History all that's really important is that its publicly readable) and you agree its appropriate, I think it would be a good idea to add to the PEP in some form.

(I'm guessing you probably also meant to link this Python-Dev thread and the first linked Python-Committers thread is the one referred

I think it would be helpful to add those links to the PEP, since you pretty much rewrote the whole thing, and in the future it would be useful to be able to refer back to those threads.

Absolutely. You could list those (by date) in the Post-History, and the new logic in #2467 will give them a nice little title-text with <target name> <target type>, e.g. Python-Committers thread.

Given the extent of the changes and the varying directness of the connection to the PEP, it might make sense to include a note admonition at the top mentioning that the PEP was substantially rewritten to introduce the "tier" model for platform support and linking the three threads (E.g. As initially prompted by `a Python-Dev thread`_, discussed in `a Python-Committers thread`_ and further refined in `a followup thread`_, this PEP was substantially revised in April 2022 to define a "tier" model for platform support.), and possibly only listing the main Python-Comitters thread in the Post-History. Your call (though happy to help do the mechanical work of adding it, if you like).

@corona10 corona10 deleted the pep-11-typo branch April 20, 2022 08:02
@vstinner
Copy link
Member

@brettcannon Don't we have to update Post-History: section for your supported-tier?

Right: I created #2544 for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants