PEP 484: Fix citation references #2638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think it would be good to have each PEP be standalone -- should PEP 482 ever change, we might inadvertently introduce build errors on this PEP. Probably better to turn it into an inline link here, as the rendering is already odd as the markup is a reST citation rather than a reST footnote (which must either begin with
A |
|
Actually, all the citations in PEP-484 have no content beyond links -- I'd support inlining them all, especially as it is a reasonably well referenced document. A |
|
Updated! |
AA-Turner
approved these changes
Jun 8, 2022
|
Line 49 needs to be similarly updated (can't add a review comment) A |
|
Thanks, done! |
AA-Turner
approved these changes
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some Sphinx build warnings.
(for readability, paths trimmed in warnings shown here)
This was a misplaced underscore, now fixed.
The exact same citation is already defined in
pep-482.txt, Sphinx uses that one.These aren't actually used in this file, we can delete them.
Also remove the redundant emacs metadata from the end of the file.