Skip to content

PEP 601: Fix footnotes #2736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 28, 2022
Merged

PEP 601: Fix footnotes #2736

merged 5 commits into from
Jul 28, 2022

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Jul 27, 2022

Fix these warnings:

pep-0601.txt:223: WARNING: Footnote [1] is not referenced.
pep-0601.txt:225: WARNING: Footnote [2] is not referenced.
pep-0601.txt:227: WARNING: Footnote [3] is not referenced.
pep-0601.txt:229: WARNING: Footnote [4] is not referenced.
pep-0601.txt:231: WARNING: Footnote [5] is not referenced.
pep-0601.txt:233: WARNING: Footnote [6] is not referenced.
pep-0601.txt:235: WARNING: Footnote [7] is not referenced.
pep-0601.txt:237: WARNING: Footnote [8] is not referenced.
pep-0601.txt:239: WARNING: Footnote [9] is not referenced.

It was using [1] instead of [1]_.

Also:

  • Remove redundant emacs metadata
  • Fix footnote links
  • Add some inline code formatting

@hugovk hugovk added the bug label Jul 27, 2022
@hugovk hugovk requested a review from isidentical as a code owner July 27, 2022 11:03
CAM-Gerlach
CAM-Gerlach approved these changes Jul 28, 2022
View reviewed changes
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, there are maybe more pressing concerns than adding literals to an old rejected PEP, but now that the work is done I don't see what not, I guess. One comment on one of the link replacements, otherwise LGTM, thanks.

@hugovk @CAM-Gerlach
PEP 601: Fix link to version active at time of writing
1489d12 
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
@hugovk hugovk merged commit 3a79e80 into python:main Jul 28, 2022
@hugovk hugovk deleted the pep601-fix-footnotes branch July 28, 2022 09:41
@hugovk hugovk mentioned this pull request Jan 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CAM-Gerlach CAM-Gerlach CAM-Gerlach approved these changes

@isidentical isidentical isidentical approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hugovk @CAM-Gerlach @isidentical