Skip to content

Many PEPs: 'Author' must be list of 'Name <email@example.com>, ...' #2809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 5, 2022
Merged

Many PEPs: 'Author' must be list of 'Name <email@example.com>, ...' #2809

merged 8 commits into from
Oct 5, 2022

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Oct 3, 2022

Prep for #2672.

  • Enable the validate-author check for .txt PEPs
  • Reformat the old email@example.com (Name) headers to Name <email@example.com>
  • Whilst editing those files, also remove the redundant emacs metadata
  • And fix the couple of footnote warnings in PEPs 3 and 231:
pep-0003.txt:72: WARNING: Footnote [1] is not referenced.
pep-0231.txt:616: WARNING: Footnote [8] is not referenced.

@hugovk hugovk added bug infra Core infrastructure for building and rendering PEPs labels Oct 3, 2022
@hugovk hugovk force-pushed the fix-author-format branch from 6066814 to 42f5a07 Compare October 4, 2022 22:08
@hugovk hugovk requested a review from ncoghlan as a code owner October 4, 2022 22:08
@hugovk
Copy link
Member Author

hugovk commented Oct 4, 2022

Updated with suggestions from CAM:

  • Infra: Remove redundant validate-author-legacy pre-commit check, now that validate-author runs for both rst and txt
  • PEP 1: Remove redundant sentence, now we only have the new author format
  • And whilst we're editing these files, also remove redundant Version and Last-Modified headers

@hugovk hugovk removed the request for review from ncoghlan October 4, 2022 22:15
CAM-Gerlach
CAM-Gerlach approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks @hugovk !

@CAM-Gerlach CAM-Gerlach removed the bug label Oct 4, 2022
@hugovk hugovk merged commit 5fb8b28 into python:main Oct 5, 2022
@hugovk hugovk deleted the fix-author-format branch October 5, 2022 16:48
@hugovk hugovk mentioned this pull request Jan 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@Mariatta Mariatta Mariatta approved these changes

@CAM-Gerlach CAM-Gerlach CAM-Gerlach approved these changes

Assignees
No one assigned
Labels
infra Core infrastructure for building and rendering PEPs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hugovk @JelleZijlstra @Mariatta @CAM-Gerlach