Skip to content

PEP 582: Add Rationale section #2966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Conversation

kushaldas
Copy link
Member

Adds Rationale section to the PEP

@kushaldas kushaldas merged commit c34268d into python:main Jan 17, 2023
@kushaldas kushaldas deleted the 582_rationale branch January 17, 2023 13:20
@brettcannon
Copy link
Member

@kushaldas FYI we try to make sure the PEP number is in the title so people know what the PR is about. Otherwise this sort of title is hard to understand when you're looking at your GitHub notifications. 😉

@CAM-Gerlach CAM-Gerlach changed the title Adds Rationale section in the PEP PEP 582: Add Rationale section Jan 19, 2023
@CAM-Gerlach
Copy link
Member

(Like this)

Also, while it is already mentioned in our existing PR template, our new templates/checklists in #2956 should make it more obvious and harder to miss—while it doesn't currently, we could add it as a checkbox item for all PRs, which would take up less space while being harder to miss then the present template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants