Skip to content

Meta: Rename PR templates to be more descriptive in the GitHub UI #2998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 1, 2023
Merged

Meta: Rename PR templates to be more descriptive in the GitHub UI #2998

merged 2 commits into from
Feb 1, 2023

Conversation

CAM-Gerlach
Copy link
Member

Followup to #2956 , as there was no way to test any of this before pushing it live to the production repo. This:

  • Remove the data block at the top of each template that apparently isn't currently used by the present GitHub implementation of the feature
  • Gives the templates more descriptive and human-readable names since it's the filenames that are displayed directly in the UI.
  • Is clearer about the purpose of the Other template (Infra/Meta), since GitHub also provides a blank option
  • Also trims an unnecessary title heading from most of the templates to slim them down further

Hopefully we can merge this quickly to avoid this issue lingering for anyone who submits a PR.

@CAM-Gerlach CAM-Gerlach added infra Core infrastructure for building and rendering PEPs meta Related to the repo itself and its processes labels Feb 1, 2023
@CAM-Gerlach CAM-Gerlach requested a review from hugovk February 1, 2023 20:57
@CAM-Gerlach CAM-Gerlach requested a review from a team as a code owner February 1, 2023 20:57
@CAM-Gerlach CAM-Gerlach removed the infra Core infrastructure for building and rendering PEPs label Feb 1, 2023
@CAM-Gerlach CAM-Gerlach mentioned this pull request Feb 1, 2023
Merged
@CAM-Gerlach CAM-Gerlach self-assigned this Feb 1, 2023
hugovk
hugovk approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge when ready 👍

@brettcannon brettcannon changed the title Meta: Rename PR templates to be more descriptive in the GitHu UI Meta: Rename PR templates to be more descriptive in the GitHub UI Feb 1, 2023
@CAM-Gerlach CAM-Gerlach merged commit 40f1df9 into python:main Feb 1, 2023
@CAM-Gerlach CAM-Gerlach deleted the rm-pr-template-data-block branch February 1, 2023 22:45
@CAM-Gerlach CAM-Gerlach mentioned this pull request Feb 1, 2023
Merged
@CAM-Gerlach
Copy link
Member Author

Looking better now, thanks:

image

Only one little tweak—the "Other" entry needs the "Other" to sort properly and not look out of place with the, erm, others. I opened #3000 to do that.

@CAM-Gerlach CAM-Gerlach mentioned this pull request Feb 1, 2023
Merged
@CAM-Gerlach
Copy link
Member Author

Err, #3001 now

@webknjaz webknjaz mentioned this pull request Feb 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk approved these changes

Assignees

@CAM-Gerlach CAM-Gerlach

Labels
meta Related to the repo itself and its processes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CAM-Gerlach @hugovk