Skip to content

Added whitespace peeve for before attribute access #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

IanLee1521
Copy link

This missing advice came up on PyCQA/pycodestyle#553.

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

Unfortunately we couldn't find an account corresponding to your GitHub username at bugs.python.org (b.p.o). If you don't already have an account at b.p.o, please create one and make sure to add your GitHub username. If you do already have an account at b.p.o then please go there and under "Your Details" add your GitHub username.

And in case you haven't already, please make sure to sign the PSF contributor agreement (CLA); we can't legally look at your contribution until you have signed the CLA.

Once you have done everything that's needed, please reply here and someone will verify everything is in order.

@IanLee1521
Copy link
Author

Oops, hadn't updated my b.p.o profile. Just did!

@brettcannon
Copy link
Member

Have you talked to any of the PEP authors about this change (I have not seen it brought up on python-dev)? You will need one of the PEP authors to okay this before we can merge it.

@Rosuav
Copy link
Contributor

Rosuav commented Jun 29, 2016

To be honest, though, I doubt this is a controversial recommendation. The debate (if there is any) would be more "Do we even need to say this?" rather than "Is this duff advice?".

@warsaw
Copy link
Member

warsaw commented Jun 29, 2016

@Rosuav Yes, that's my opinion. PEP 8 isn't a legal document so it doesn't need to spell out every single detail. This just seems unnecessary. I'm going to close this PR, and if any of the other PEP authors want to debate it further, we can reopen it.

@warsaw warsaw closed this Jun 29, 2016
lukpueh pushed a commit to lukpueh/peps that referenced this pull request Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants