PEP 728: Fix formatting and code highlighting issues. #3659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zixuan James Li <p359101898@gmail.com>
Signed-off-by: Zixuan James Li <p359101898@gmail.com>
JelleZijlstra
approved these changes
Feb 9, 2024
|
Thanks! Looks good! Whilst I'm looking at it now (and sorry for not reviewing on the first pass, but these are minor things :), there's a few places with a bit too much indentation, which shows up as quoted text: 
Plus one code block (line 417) that's shown as regular text. Shall we fix these too? By the way, good work with the movie examples! Much easier to follow than foo and bar. |
9574c32 to
abdb96e
Compare
Signed-off-by: Zixuan James Li <p359101898@gmail.com>
Signed-off-by: Zixuan James Li <p359101898@gmail.com>
|
Thanks for the reviews! I fixed the code blocks and some other issues. Also updated the type consistency part to make the edits stand out. I plan on doing another PR focusing on content changes after getting more feedback from the discussion post. |
|
Thanks! These too: 
|
|
@hugovk I think those are essential, they are (modified) quotes from the existing spec. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update addresses @hugovk comments.
📚 Documentation preview 📚: https://pep-previews--3659.org.readthedocs.build/