Skip to content

Remove legacy formatters from py list error output #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 1, 2025

Conversation

AA-Turner
Copy link
Member

Currently:

PS> py list --format spam
...

[ERROR] 'spam' is not a valid format; expect one of: csv, exe, id, json, jsonl, legacy, legacy-paths, prefix, table, url

However, the help output only lists --format=<table,json,jsonl,id,exe,prefix>. This PR removes the two 'legacy' entries, but keeps CSV and URL, as it might be useful to hint that these exist.

A

@zooba
Copy link
Member

zooba commented May 1, 2025

However, the help output only lists --format=<table,json,jsonl,id,exe,prefix>.

An oversight. Want to add CSV and URL to the help output? They're roughly prioritised in "how likely you should prefer it", which is why it's hard coded instead of generated.

Totally okay with excluding the legacy ones from the output.

@zooba
Copy link
Member

zooba commented May 1, 2025

Created #55 so I can merge this now.

@zooba zooba merged commit c46da6c into main May 1, 2025
5 checks passed
@zooba zooba deleted the list-help-no-legacy branch May 1, 2025 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants