Skip to content

Add support for multiple benchmark groups in a manifest #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 9, 2022
Merged

Add support for multiple benchmark groups in a manifest #192

merged 3 commits into from
May 9, 2022

Conversation

kmod
Copy link
Contributor

@kmod kmod commented May 4, 2022

Previously they would show up as conflicts on the "group" section

kmod added 3 commits May 4, 2022 19:29
@kmod
Add support for multiple benchmark groups in a manifest
2c59bec 
Previously they would show up as conflicts on the "group" section
@kmod
Add a note to the help on how to run groups
8c046b5
@kmod
Fix up groups-referencing-groups
b344833 
This code might never have been triggered before if multiple groups weren't supported
ericsnowcurrently
ericsnowcurrently approved these changes May 9, 2022
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericsnowcurrently ericsnowcurrently merged commit c58b771 into python:main May 9, 2022
@ericsnowcurrently
Copy link
Member

Thanks for tackling this, @kmod!

@kmod kmod mentioned this pull request Aug 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kmod @ericsnowcurrently