Skip to content

Allow contributors to manually run tests on their GitHub forks #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2023
Merged

Allow contributors to manually run tests on their GitHub forks #269

merged 1 commit into from
Mar 7, 2023

Conversation

AlexWaygood
Copy link
Member

Makes it easier to debug CI issues without creating a PR

@AlexWaygood
Allow contributors to manually run tests on their GitHub forks
55b969d 
Makes it easier to debug CI issues without creating a PR
@AlexWaygood
Copy link
Member Author

(The failing tests are unrelated to this PR.)

hugovk
hugovk approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And also remove the branch restrictions to allow contributors to automatically run tests on their forks?

 on:
   push:
-    branches: [main]
   pull_request:
-    branches: [main]

Nearly all PRs here come from forks, so we don't need to worry about duplicate builds.

@AlexWaygood
Copy link
Member Author

AlexWaygood commented Mar 7, 2023 •
edited
Loading

And also remove the branch restrictions to allow contributors to automatically run tests on their forks?

 on:
   push:
-    branches: [main]
   pull_request:
-    branches: [main]

Nearly all PRs here come from forks, so we don't need to worry about duplicate builds.

That one's slightly more controversial, so I'll leave it to a separate PR ;)

@AlexWaygood AlexWaygood merged commit 4a69828 into main Mar 7, 2023
@AlexWaygood AlexWaygood deleted the AlexWaygood-patch-1 branch March 7, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexWaygood @hugovk