Skip to content

Expose --min-time from pyperf to pyperformance CLI #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

diegorusso
Copy link
Contributor

The user can now control the minimum time a benchmark should run directly from the CLI via --min-time which then is passed to pyperf.

The user can now control the minimum time a benchmark should run
directly from the CLI via --min-time which then is passed to pyperf.
@corona10 corona10 requested a review from vstinner June 13, 2023 09:29
@corona10
Copy link
Member

@vstinner Can you please take a look at?

@diegorusso
Copy link
Contributor Author

I give another ping on this.. if there anything that feels to be modified, let me know.

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can someone merge this PR?

@hugovk hugovk merged commit 662454d into python:main Sep 27, 2023
@hugovk
Copy link
Member

hugovk commented Sep 27, 2023

Thanks!

@diegorusso diegorusso deleted the min-time branch September 28, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants