Pequeñas mejoras al proceso de construcción #2874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doing so means we now can reuse the logic that fixes the include:: directives in the cpython documentation in our CI job, avoiding repeating ourselves, making maintenance easier and avoiding subtle bugs. Being able to reuse the rest of the steps (do_build, pospell, etc) requires more care, as the Makefile is constrained to requiring a virtual environment (which we don't create on CI), and also doesn't allow us to pass command-line arguments to list specific files to check. Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
Some of these replacements didn't exist anymore, while others seemed like accidental duplicates that might or might not have been needed to begin with. Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
This version performs .po file updates in parallel, thus speeding up the process of moving to new versions of Python and updating our translation files. Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
cmaureir
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Éstos son pequeños cambios que mejoran ligeramente el proceso de la construcción de la documentación, y hacen más mantenible el código a futuro.
Primero, la lista de rutas relativas que hay que arreglar en los .rst de cpython ha sido simplificada, removiendo entradas innecesarias, y actualizando sólo los archivos que haga falta (en vez de ejecturas cada actualización sobre todos los archivos cada vez).
Segundo, el target
builddel Makefile fue separado en sus sub-partes constituyentes, de tal modo que ahora en el step de CI donde antes teníamos una copia de los comandossedahora hay sólo una invocación amake fix_relative_paths.Finalmente, el PR que envié a
sphinx-intlpara realizar updates en paralelo ya está aceptado y una nueva versión ya fue publicada, por lo que la lista de requisitos ahora está actualizada para usar esa última versión (y así hacer más rápido el proceso de actualización a 3.13).