Skip to content

Traducido library/logging.config #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 25, 2020
Merged

Traducido library/logging.config #456

merged 7 commits into from
Jul 25, 2020

Conversation

cmaureir
Copy link
Collaborator

@cmaureir cmaureir commented Jun 26, 2020 •
edited
Loading

Me hice bastante lio con este archivo... hay mucho texto entre comillas dobles que no estaba seguro si traducirlo o no.
Además, hacían mucha referencia a dict cuando hablaban del diccionario central del módulo, con lo que lo cambié a diccionario.
Espero les sirva para ser más criticos con esos conceptos.

Closes #422

narvmtz
narvmtz reviewed Jul 25, 2020
View reviewed changes
Copy link
Contributor

@narvmtz narvmtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gracias @cmaureir! Estuvo un poco complejo el archivo, pero la traducción estuvo a su misma altura.

Dejé varios comentarios con cambios pequeños, luego de esto creo que estaría listo :)

cmaureir and others added 2 commits July 25, 2020 18:07
@cmaureir @narvmtz
Apply suggestions from code review
0743e07 
Co-authored-by: narvmtz <51009725+narvmtz@users.noreply.github.com>
@cmaureir
Merge remote-tracking branch 'upstream/3.8' into traduccion-library-l…
1c7e7d4 
…ogging-config
@gilgamezh gilgamezh assigned gilgamezh and unassigned gilgamezh Jul 25, 2020
@narvmtz narvmtz self-assigned this Jul 25, 2020
@gilgamezh gilgamezh removed their assignment Jul 25, 2020
@narvmtz narvmtz self-requested a review July 25, 2020 16:28
narvmtz
narvmtz approved these changes Jul 25, 2020
View reviewed changes
Copy link
Contributor

@narvmtz narvmtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muchas gracias @cmaureir tremendo trabajo 🎉

@cmaureir cmaureir merged commit 5612ec0 into python:3.8 Jul 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@narvmtz narvmtz narvmtz approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@narvmtz narvmtz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Translate library/logging.config.po
3 participants
@cmaureir @narvmtz @gilgamezh