Skip to content

Use one dictionary per file #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 13, 2020
Merged

Use one dictionary per file #547

merged 2 commits into from
Jul 13, 2020

Conversation

humitos
Copy link
Collaborator

@humitos humitos commented Jul 11, 2020

We had a lot of conflict using a shared dict file for all the PRs. We are
using a simpler approach now where we create a dictionary file per .po
translated to avoid this conflicts.

When calling pospell, we concatenate all these files together and use the result
to call pospell properly.

We had a lot of conflict using a shared `dict` file for all the PRs. We are
using a simpler approach now where we create a dictionary file per .po
translated to avoid this conflicts.

When calling pospell, we concatenate all these files together and use the result
to call pospell properly.
@humitos humitos requested review from cmaureir and raulcd July 11, 2020 11:07
@cmaureir
Copy link
Collaborator

quizás deberíamos agregar el dict.txt al .gitignore, ya que puede que la gente lo agregue cuando hace el build local.
Agregaste el archivo dictionaries/library_decimal.txt para cuando la gente lea la documentación el archivo exista? o se te pasó?

@humitos
Copy link
Collaborator Author

humitos commented Jul 11, 2020

quizás deberíamos agregar el dict.txt al .gitignore, ya que puede que la gente lo agregue cuando hace el build local.

Buen punto. Ahí lo puse.

Agregaste el archivo dictionaries/library_decimal.txt para cuando la gente lea la documentación el archivo exista? o se te pasó?

Sí, lo dejé ahí de ejemplo para tener un archivo dentro de ese directorio.

@humitos humitos merged commit 6ed4ada into 3.8 Jul 13, 2020
@humitos humitos deleted the dict-faq branch July 13, 2020 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants