Skip to content

docs: translate library/bz2 #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2020
Merged

docs: translate library/bz2 #635

merged 1 commit into from
Jul 28, 2020

Conversation

woile
Copy link
Contributor

@woile woile commented Jul 26, 2020 •
edited by cmaureir
Loading

Closes #583

@woile woile force-pushed the traduccion-library-bz2 branch from 308a57e to d9544c9 Compare July 26, 2020 17:41
spiccinini
spiccinini reviewed Jul 27, 2020
View reviewed changes
@woile woile force-pushed the traduccion-library-bz2 branch from d9544c9 to 30aa37e Compare July 27, 2020 18:25
Jighdan
Jighdan reviewed Jul 27, 2020
View reviewed changes
Copy link
Contributor

@Jighdan Jighdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@woile parece que en la linea 478 te falto un acento grave:

msgstr "Aquí hay algunos ejemplos del uso típico del modulo :mod:`bz2."

Cambia a:
msgstr "Aquí hay algunos ejemplos del uso típico del modulo :mod:bz2."

@woile woile force-pushed the traduccion-library-bz2 branch 2 times, most recently from 557665a to 3614d07 Compare July 27, 2020 19:01
cmaureir
cmaureir requested changes Jul 27, 2020
View reviewed changes
Copy link
Collaborator

@cmaureir cmaureir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gracias @woile por todo el trabajo! dejé comentarios menos relacionados a estándares que tenemos en la memoria, pero estaba super bien en general :).
Si aplicas las sugerencias, de seguro tienes que pasarle un 'powrap' al archivo. (No te olvides de mantener tu rama local actualizada!) 👯

@woile woile force-pushed the traduccion-library-bz2 branch 2 times, most recently from 7c31c86 to 8a7fe63 Compare July 28, 2020 07:43
@woile woile force-pushed the traduccion-library-bz2 branch from 8a7fe63 to 576a48c Compare July 28, 2020 08:19
@cmaureir
Copy link
Collaborator

Gracias @woile por tremendo trabajo 🎉 🎉
Para las futuras traducciones, decidimos no hacer --amend y push -f, así que siéntete libre de tener una cadena de cambios sobre algún PR ;)

@cmaureir cmaureir merged commit 6c9edf3 into python:3.8 Jul 28, 2020
@woile
Copy link
Contributor Author

woile commented Jul 28, 2020

De nada! La verdad estoy acostumbrado así por el trabajo 😅

@cmaureir
Copy link
Collaborator

De nada! La verdad estoy acostumbrado así por el trabajo sweat_smile

pues yo hacia exactamente lo mismo en mis primeros PRs acá hahaha, así que te entiendo :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiccinini spiccinini spiccinini left review comments

@Jighdan Jighdan Jighdan left review comments

@cmaureir cmaureir cmaureir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Translate library/bz2.po
4 participants
@woile @cmaureir @spiccinini @Jighdan