Skip to content

Use date-based release numbers #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 2, 2018
Merged

Use date-based release numbers #11

merged 2 commits into from
Feb 2, 2018

Conversation

theacodes
Copy link
Collaborator

No description provided.

@theacodes theacodes mentioned this pull request Feb 2, 2018
Closed
ncoghlan
ncoghlan approved these changes Feb 2, 2018
View reviewed changes
Copy link
Contributor

@ncoghlan ncoghlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (although I'd suggest "year.month[.serial]" for the comment, since the most likely reason for multiple releases in a single month is because there was a build-breaking bug in one of them)

@theacodes
Copy link
Collaborator Author

Good point, done!

@theacodes theacodes merged commit 2a7d0cc into master Feb 2, 2018
@theacodes theacodes deleted the jonparrott-date-based-releases branch February 2, 2018 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncoghlan ncoghlan ncoghlan approved these changes

@Mariatta Mariatta Awaiting requested review from Mariatta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theacodes @ncoghlan