Consistently reference theme_root_icon
#163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed explicit py.svg references with theme_root_icon paths
|
All commit authors signed the Contributor License Agreement. |
ezio-melotti
approved these changes
Jan 9, 2024
|
Good idea. Although "Logo" isn't a great alt text, can we also add something like |
310da0a to
7c36c8e
Compare
… layout.html This fixes a partial integration of root_icon and adds the new variable root_icon_alt_text
7c36c8e to
099019d
Compare
hugovk
reviewed
Jan 10, 2024
Capitalization fix Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
|
Thank you for suggestions! |
Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
AA-Turner
requested changes
Jan 12, 2024
There was a problem hiding this comment.
Per the documentation:
This, however, is not the preferred way to concatenate strings! For string concatenation, have a look-see at the
~operator.
https://jinja.palletsprojects.com/en/3.1.x/templates/#other-operators
~(tilde)Converts all operands into strings and concatenates them.
As
theme_root_icon
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed explicit
py.svgreferences inlayout.htmlwiththeme_root_iconpaths.This pull request changes paths lines 17 and 103 to match line 74 in the base branch.