Skip to content

make the search button wider #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2018
Merged

make the search button wider #17

merged 1 commit into from
Jul 10, 2018

Conversation

zhsj
Copy link
Contributor

@zhsj zhsj commented Jul 10, 2018 •
edited
Loading

when the word "Go" translated to "查找" in Chinese, this button seems too narrow.
See example on https://zhsj.github.io/python-docs-zh-cn/

@zhsj
make the search button wider
8c2ba04 
when the word "Go" translated to "搜索" in Chinese, this button seems too narrow.
See example on https://zhsj.github.io/python-docs-zh-cn/
zware
zware approved these changes Jul 10, 2018
View reviewed changes
Copy link
Member

@zware zware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it's even a bit cramped for English right now.

@theacodes theacodes merged commit 68b11a1 into python:master Jul 10, 2018
@zhsj zhsj deleted the patch-1 branch October 23, 2018 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zware zware zware approved these changes

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhsj @zware @theacodes @the-knights-who-say-ni