Fix codebgcolor and codetextcolor for Sphinx 3.1.0+ #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sphinx 3.1.0+ dropped the custom codebgcolor and codetextcolor from the classic theme[1], leaving pre elements uncolored. [1] sphinx-doc/sphinx@b345acc
zmwangx
added a commit
to zmwangx/dim
that referenced
this pull request
Oct 10, 2020
See python/python-docs-theme#57. Also blacken.
|
Wait, was this change intentional? Just noticed that Python 3.10 docs, rendered with Sphinx 3.2.1, features background color-less code blocks. In any case I certainly prefer the old style. |
|
Looks related to sphinx-doc/sphinx#7720 / sphinx-doc/sphinx#7721 |
|
Yeah, sphinx-doc/sphinx#7720 led to sphinx-doc/sphinx#7721 led to sphinx-doc/sphinx@b345acc. |
pablogsal
approved these changes
Dec 19, 2020
|
@Mariatta Do you happen to know who has privileges to publish a new version to pypi? We need a new version to restore the colourized backgrounds. |
|
I can publish this later this evening. |
|
We've released v 2020.12 |
|
Thanks a lot @Mariatta! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sphinx 3.1.0+ dropped the custom
codebgcolorandcodetextcolorfrom the classic theme (see commit sphinx-doc/sphinx@b345acc), leaving pre elements uncolored.Without the fix:
Should be: