Skip to content

Use default pygments theme #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2021
Merged

Conversation

Blendify
Copy link
Contributor

The default theme looks a lot better than the default theme with the green background.

The default theme looks a lot better than the default theme with the green background.
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@Blendify

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@JulienPalard
Copy link
Member

Before :
Screenshot_2021-03-23 http client — HTTP protocol client — Python 3 9 2 documentation(1)
After :
Screenshot_2021-03-23 http client — HTTP protocol client — Python 3 9 2 documentation

@pradyunsg
Copy link
Member

Is anything blocking this merging?

@JulienPalard
Copy link
Member

I think it's subjective, I fear someone will open a PR to use Sphinx instead of defaut telling it looks better and we enter an infinite loop.

So what's blocking this PR is the lack of concensus. Maybe open an poll on discuss.python.org or twitter, and if the concensus is clear, we could merge this.

  • I see one good point: redish literals do pop out cleaner.
  • I see one bad point: light grey output is less readable.

@pablogsal
Copy link
Member

I can apport a non-subjective point: I am very colorblind and I can read much better the second one

@JulienPalard
Copy link
Member

I can apport a non-subjective point: I am very colorblind and I can read much better the second one

Thanks for your feedback!

@JulienPalard JulienPalard merged commit 5586486 into python:master May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants