Skip to content

Remove id searchbox on mobile to fix a layout bug #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2021
Merged

Remove id searchbox on mobile to fix a layout bug #76

merged 1 commit into from
May 12, 2021

Conversation

obulat
Copy link
Contributor

@obulat obulat commented May 9, 2021

Sphinx in doctools.js uses an element with id searchbox to append a paragraph saying "Hide search matches". It is currently not used in the Python docs, but with the responsive theme, it breaks the layout. The search box at the top has a "Hide search matches" link to the right of it:

Screen Shot 2021-05-09 at 12 03 48 PM

To reproduce:

  1. Go to the 3.11 version of the docs
  2. Narrow your screen to mobile width
  3. Search for something (eg. "xml rpc")
  4. Click on one of the search results (eg. "xmlrpc.client — XML-RPC client access")

I removed the id from the search form in the top menu bar so that this link is not added.

@JulienPalard JulienPalard merged commit 4dcc3b4 into python:master May 12, 2021
@JulienPalard
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@obulat @JulienPalard @the-knights-who-say-ni