-
-
Notifications
You must be signed in to change notification settings - Fork 65
Bugfix: quote monospace font #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
For some reason, saying just `monospace` here doesn't seem to work on chrome mobile. Quoting monospace fixes the issue.
See https://twitter.com/sadhlife/status/1446060335979397120 for the sleuthing :) |
Good work! As it happens, this is fixed in the upcoming Chrome 96: python/pythondotorg#1708 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Despite the upcoming fix in Chrome, this is such a simple fix, I think it's worth merging for people who will still be on Chrome < 96, even after Chrome 96 release.
(Plus for people using latest Chrome 94 now :)
Oh this kind of bugs … ☹ |
Thanks @tusharsadhwani and @nedbat! |
I released it as python-docs-theme 2021-11 (I live in the future) and rebuilt https://docs.python.org/3/ so someone can check. Rebuild for other versions and languages will be automatically done in the next 24h. |
This "fix" broke the font for me. My Chrome on my Mac is now loading Helvetica for code rather than Courier. I can confirm that removing the quotes from |
Chrome, showing 3 different behaviours on 3 operating systems. A tale as old as time. |
Perhaps the best fix is to just specify monospace. Why a fallback to sans-serif? Does any browser not have a monospace font that is used when you specify monospace? |
Removing the quotes from monospace even with it being the only specified font breaks on current chrome mobile. |
So... Do we need one monospace with quotes and one monospace without quotes? 🙃
The problem seems to be desktop isn't picking up the "monospace" and falling back to sans-serif. If we remove sans-serif, it'll fall back to some system default, which will be some sans-serif or serif, but not monospace. |
Okay, I tested on 3.9's page, and it seems just pre {
font-family: monospace;
} seems to work. Can someone test it on all 3 platforms, android mac and windows, that'd be great. |
Noticed my Firefox 93.0 on win10 is weirded by |
✨ This is an old work account. Please reference @brandonchinn178 for all future communication ✨ Can confirm, currently fonts on |
Can confirm, works fine. Even on mobile where just |
There is (or was) a known problem with plain And necolas/normalize.css#519 (comment) suggests a reason, browsers looked for the fixed string |
Ah, that makes sense now. So I guess |
@beauremus Thanks a bunch. |
For some reason, saying just
monospace
here doesn't seem to work on chrome mobile. Quoting monospace fixes the issue.Before:

After:
