Skip to content

Sync with CPython 3.9 #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Sep 17, 2021
Merged

Sync with CPython 3.9 #105

merged 13 commits into from
Sep 17, 2021

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 7, 2021

Sync with CPython 3.9

@mattwang44
Copy link
Collaborator

mattwang44 commented Sep 7, 2021

@adrianliaw I'll keep working on this PR but I need permission to push changes on this branch. Can you grant me the write permission of this repo? or do you prefer me to create a new branch/PR from this branch for syncing?

@mattwang44
Copy link
Collaborator

mattwang44 commented Sep 7, 2021

Currently, the PR created by the github action does not trigger another workflow (e.g. CI pipeline). One of the workaround is simply close and reopen the PR.
See #107 for details.

It's solved by #108

@mattwang44 mattwang44 closed this Sep 7, 2021
@mattwang44 mattwang44 reopened this Sep 7, 2021
@github-actions github-actions bot force-pushed the cron/sync/3.9 branch 3 times, most recently from 19a5921 to abe4b3a Compare September 10, 2021 00:13
@mattwang44
Copy link
Collaborator

mattwang44 commented Sep 10, 2021

@adrianliaw I believe this PR is safe to be merged now since

@pydoc-zh-tw pydoc-zh-tw bot force-pushed the cron/sync/3.9 branch 2 times, most recently from ecf161c to 97845e0 Compare September 12, 2021 00:14
@StevenHsuYL
Copy link
Contributor

The copyright.po had been handled on #93 and merged today.
The sphinx.po had been handled on #99 (not merged yet), and I found that the version tags in your sphinx commit seem not synced with the cpython. May need further review.

@mattwang44
Copy link
Collaborator

@StevenHsuYL Would you please point out which line is not synced?

@StevenHsuYL
Copy link
Contributor

StevenHsuYL commented Sep 16, 2021

In your sphinx.po file, below msgstr...
"Python 3.10 (in development)"
"Python 3.9 (pre-release)"
"Python 3.8 (stable)"
"Python 3.7 (stable)"
They're not synced with the official doc page (https://docs.python.org/zh-tw/3.9/).

By the way, I found that this section (version tags) is not "translatable" by checking doc homepages in all other languages.
(https://docs.python.org/ja/3.9/)

@mattwang44
Copy link
Collaborator

mattwang44 commented Sep 16, 2021

@StevenHsuYL
These version tags are translatable as other source strings and they're synced with python/cpython on the 3.9 branch, but the sidebar on docs.python.org are overwritten when building the docs (see the source code in python/docsbuild-scripts). That's why we cannot find the translated version tags.

@StevenHsuYL
Copy link
Contributor

@mattwang44 Thanks or reply!
I also found out that the version statuses in the sidebar were defined here in docbuild-scripts.
Should our sphinx.po file sync with these definitions as well?

But as you said, it would always be overwritten, so maybe this part is not very important in our translation project... 🙄

@mattwang44
Copy link
Collaborator

@mattwang44 Thanks or reply!
I also found out that the version statuses in the sidebar were defined here in docbuild-scripts.
Should our sphinx.po file sync with these definitions as well?

But as you said, it would always be overwritten, so maybe this part is not very important in our translation project... 🙄

I think the current version is fine and we can just leave it 👍🏽.

@adrianliaw adrianliaw merged commit 3a35894 into 3.9 Sep 17, 2021
@mattwang44 mattwang44 deleted the cron/sync/3.9 branch September 17, 2021 05:30
beccalzh pushed a commit to beccalzh/python-docs-zh-tw that referenced this pull request Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants