Skip to content

Add errors one sentence. #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Conversation

AlexWUrobot
Copy link

No description provided.

Copy link
Collaborator

@adrianliaw adrianliaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing! ✨I have some comments in the review, could you read it, please?

@@ -29,6 +30,8 @@ msgid ""
"tried out the examples you have probably seen some. There are (at least) "
"two distinguishable kinds of errors: *syntax errors* and *exceptions*."
msgstr ""
"到目前為止錯誤訊息還沒有提到,但如果你嘗試這些範例,你可能會發現一些問題。有"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first sentence should keep the SVO order in Chinese grammar, "錯誤訊息" and "還沒有提到" should be swapped.

Also, what do you mean by the word "問題"?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fix it

@@ -29,6 +30,8 @@ msgid ""
"tried out the examples you have probably seen some. There are (at least) "
"two distinguishable kinds of errors: *syntax errors* and *exceptions*."
msgstr ""
"到目前為止錯誤訊息還沒有提到,但如果你嘗試這些範例,你可能會發現一些問題。有"
"(至少)兩種明顯的錯誤分別是*語法錯誤*和*例外*。"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parentheses here should be full-width. The stars for marking the italic texts should have "un-spaced separator" put before them, as described in the translation guide.

Also, the word "分別" could be ambiguous, it could mean both "distinguishing" or "namely blah and blah", I think it would be better if some proper punctuation is attached to make the meaning unambiguous.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fix it
Thank you very much
this is my first to use it.

@AlexWUrobot AlexWUrobot changed the title Add errors one sentence. Add errors one sentence v2 fix it Oct 16, 2018
@AlexWUrobot AlexWUrobot changed the title Add errors one sentence v2 fix it Add errors one sentence. Oct 16, 2018
@adrianliaw adrianliaw closed this Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants