Skip to content

Translate one more sentence in inputoutput.po #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

iamsuperwen
Copy link
Contributor

Adding one more sentence to earn the 5th PR for Hacktoberfest, haha. 😁
Don't worry, I'll keep working on. 💪
Just the amount of completions growing extremely fast, that I'm afraid of not being the first 50,000. 😂

Copy link
Collaborator

@adrianliaw adrianliaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for another contribution! I've written some suggestions, please take a look at them if you've got a minute. Also, please do NOT reuse a previous branch unless you've explicitly removed and recreated it from master, please always follow the instructions in the contribution guideline on every single contribution (fetch and branch), and never do git pull. For this PR it's ok for me to manually exclude the merge commit 6c2fe7d and then merge, but please keep it in mind on your next one, thanks!

@@ -64,6 +64,9 @@ msgid ""
"Inside this string, you can write a Python expression between ``{`` and ``}"
"`` characters that can refer to variables or literal values."
msgstr ""
"使用\\ :ref:`格式化的字串文本 (formatted string literals) <tut-f-strings>`,"
"在字串開始前的引號或連續三個引號前加上 ``f`` 或 ``F`` 。你可以在字串中使用 "
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"在字串開始前的引號或連續三個引號前加上 ``f`` 或 ``F`` 。你可以在字串中使用 "
"在字串開始前的引號或連續三個引號前加上 ``f`` 或 ``F``。你可以在字串中使用 "

@@ -64,6 +64,9 @@ msgid ""
"Inside this string, you can write a Python expression between ``{`` and ``}"
"`` characters that can refer to variables or literal values."
msgstr ""
"使用\\ :ref:`格式化的字串文本 (formatted string literals) <tut-f-strings>`,"
"在字串開始前的引號或連續三個引號前加上 ``f`` 或 ``F`` 。你可以在字串中使用 "
"``{`` 與 ``}`` 包夾 Python 的表示式,引用變數或其他字串文本。"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latter subsentence would be better with a subject attached to avoid ambiguity. Without attaching a subject, it could be sounding like "you can write a Python expression, refer a variable, or other literal values", but it should be "you can write a Python expression that can refer to variables or other literal values", so it would be better if it's "其可以引用變數或其他字面值"

Also, here in the original sentence, it says "literal values" instead of "string literals", literal values could be string literals, integer literals, float literals etc., so it should use a different word, such as "字面值". But same as string literals, this translation does not sound familiar to any one, so it'll be better to parenthesise the original English word, just like the translation for "string literals".

@mattwang44
Copy link
Collaborator

closed by #74.

@mattwang44 mattwang44 closed this Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants