Skip to content

Translate c-api/refcounting.po #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 19, 2023
Merged

Conversation

mattwang44
Copy link
Collaborator

@mattwang44 mattwang44 commented Aug 6, 2023

translate some strings that are newly-added in 3.12 doc

preview image

@mattwang44 mattwang44 requested a review from rockleona August 7, 2023 02:22
@mattwang44
Copy link
Collaborator Author

@rockleona Please help review this PR when you're available. Thanks!

Comment on lines 257 to 258
"這會在減少 `dst` 舊值的參照計數\\ _之前_\\ 將 `dst` 設定為 `src`,使得因 "
"`dst` 被拆除而觸發的任何程式碼不會相信 `dst` 有指向一個有效物件。"
Copy link
Collaborator

@rockleona rockleona Aug 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

這句好難喔@@
我修改了一下語句看有沒有比較通順

Suggested change
"這會在減少 `dst` 舊值的參照計數\\ _之前_\\ 將 `dst` 設定為 `src`,使得因 "
"`dst` 被拆除而觸發的任何程式碼不會相信 `dst` 有指向一個有效物件。"
"這會在減少 `dst` 舊值的參照計數\\ _之前_\\ 將 `dst` 設定為 `src`,使得任何程式碼 "
"觸發了 `dst` 被拆除的副作用 (side-effect) 進而不會相信 `dst` 有指向一個有效物件。"

@mattwang44
Copy link
Collaborator Author

翻開覆蓋的陷阱卡

想麻煩 @rockleona 參與 #568 的討論,一起幫忙看看這樣變更會不會有什麼問題 🙏🏽

@rockleona
Copy link
Collaborator

輪到我的回合了

好的,我待會來去看看

Comment on lines 257 to 258
"這會在減少 `dst` 舊值的參照計數\\ _之前_\\ 將 `dst` 設定為 `src`,使得因 "
"`dst` 被拆除而觸發的任何程式碼不會相信 `dst` 有指向一個有效物件。"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • code 指的應該是被意外觸發的部分(也就是 side effect)
  • 我漏翻 side effect

如果改成這樣呢?

Suggested change
"這會在減少 `dst` 舊值的參照計數\\ _之前_\\ 將 `dst` 設定為 `src`,使得因 "
"`dst` 被拆除而觸發的任何程式碼不會相信 `dst` 有指向一個有效物件。"
"這會在減少 `dst` 舊值的參照計數\\ _之前_\\ 將 `dst` 設定為 `src`,使得因 "
"`dst` 被拆除而觸發的任何副作用 (side-effect) 之程式碼不會相信 `dst` 是"
"指向一個有效物件。"

@mattwang44
Copy link
Collaborator Author

c-api/refcounting 原文近期有不少變動,最近會再找時間補上這個 PR

@mattwang44
Copy link
Collaborator Author

c-api/refcounting 原文近期有不少變動,最近會再找時間補上這個 PR

已補

@mattwang44 mattwang44 requested a review from rockleona August 14, 2023 15:26
Copy link
Collaborator

@rockleona rockleona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看完一輪之後只能說請收下我的膝蓋吧(X)
太精準了!

@mattwang44 mattwang44 requested a review from rockleona August 18, 2023 18:15
Copy link
Collaborator

@rockleona rockleona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mattwang44 mattwang44 merged commit eda10c1 into python:3.12 Aug 19, 2023
@mattwang44 mattwang44 deleted the c-api/refcounting branch August 19, 2023 15:23
beccalzh pushed a commit to beccalzh/python-docs-zh-tw that referenced this pull request Sep 4, 2024
* translate `c-api/refcounting.po`

* fix: updated the source strings and their translations

* fix(c-api/refcounting): modify based on review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants