Skip to content

fix(action): should take default branch name as the version in CI #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

mattwang44
Copy link
Collaborator

[WHY]

If the name of the target branch is not the version name, the CI workflow would fail.

[HOW]

Take the default branch name as the version.

Copy link
Collaborator

@ken71301 ken71301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@rockleona rockleona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!
BTW,沒有官方文件真的好煩,唯一的 reference

@mattwang44 mattwang44 merged commit 77db681 into 3.12 Nov 29, 2023
@mattwang44 mattwang44 deleted the fix-ci-action-version-name branch November 29, 2023 06:07
isabellechiu pushed a commit to isabellechiu/python-docs-zh-tw that referenced this pull request Dec 5, 2023
beccalzh pushed a commit to beccalzh/python-docs-zh-tw that referenced this pull request Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants