Skip to content

translate library/weakref.po #857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2024
Merged

translate library/weakref.po #857

merged 1 commit into from
May 9, 2024

Conversation

ken71301
Copy link
Collaborator

No description provided.

@ken71301 ken71301 force-pushed the translate-weakref branch from 44aa3ce to 6796d4e Compare March 26, 2024 12:48
@ken71301 ken71301 marked this pull request as ready for review March 26, 2024 13:42
@ken71301 ken71301 force-pushed the translate-weakref branch from ab9b9ad to b04da9d Compare March 28, 2024 13:31
@ken71301
Copy link
Collaborator Author

ready for review~

@ken71301 ken71301 requested a review from rockleona April 19, 2024 14:19
rockleona
rockleona reviewed Apr 20, 2024
View reviewed changes
Copy link
Collaborator

@rockleona rockleona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

抓時間 review 到 L116

mattwang44
mattwang44 reviewed Apr 26, 2024
View reviewed changes
@mattwang44 mattwang44 self-requested a review April 29, 2024 07:50
rockleona
rockleona reviewed May 8, 2024
View reviewed changes
Copy link
Collaborator

@rockleona rockleona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finished Reivew

@ken71301 ken71301 requested a review from rockleona May 8, 2024 12:45
@ken71301 ken71301 force-pushed the translate-weakref branch 2 times, most recently from 818749f to 466d7ac Compare May 8, 2024 12:56
mattwang44
mattwang44 reviewed May 8, 2024
View reviewed changes
mattwang44
mattwang44 reviewed May 8, 2024
View reviewed changes
@ken71301 @mattwang44
fix: Inline literal start-string without end-string.
8a8703e 
feat: to rst:264

Update library/weakref.po

Co-authored-by: RockLeon <34214497+rockleona@users.noreply.github.com>

Apply suggestions from code review

Co-authored-by: RockLeon <34214497+rockleona@users.noreply.github.com>

Apply suggestions from code review

Co-authored-by: Wei-Hsiang (Matt) Wang <mattwang44@gmail.com>

fix: Apply suggestions from code review

Apply suggestions from code review

Co-authored-by: Wei-Hsiang (Matt) Wang <mattwang44@gmail.com>
@ken71301 ken71301 force-pushed the translate-weakref branch from 23351d6 to 8a8703e Compare May 9, 2024 01:55
@rockleona rockleona enabled auto-merge (squash) May 9, 2024 02:13
@rockleona rockleona merged commit c79e8b2 into python:3.12 May 9, 2024
1 check passed
@ken71301 ken71301 deleted the translate-weakref branch May 14, 2024 11:59
@mattwang44 mattwang44 mentioned this pull request Sep 26, 2024
Closed
@mattwang44 mattwang44 linked an issue Sep 26, 2024 that may be closed by this pull request
Translate library/weakref.po #856
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattwang44 mattwang44 mattwang44 approved these changes

@rockleona rockleona Awaiting requested review from rockleona

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Translate library/weakref.po
3 participants
@ken71301 @mattwang44 @rockleona