-
Notifications
You must be signed in to change notification settings - Fork 623
Sponsorships notifications #1869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dd943bd
to
91839e1
Compare
@ewdurbin this PR now has all the other feature we've discussed during our last meeting. The only thing missing is the preview part of the it. I still have to figure our how to implement this, but the great part of the email dispatch work is done and can be reviewed. |
Now this PR also includes the preview step |
ewdurbin
approved these changes
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new app named
mailing
to hold all the code related to DB stored emails' notification templates. This app also exposes base classes to extend its usage within django admin and forms.The
sponsors
app now has a new model to define notifications that should be sent to sponsors. To send them, the user can access theSponsorship
list admin, filter and select the ones which have theEmailTargetable
benefit feature to send the desired notification.TODO: