Skip to content

Sponsorships notifications #1869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 32 commits into from
Oct 7, 2021
Merged

Conversation

berinhard
Copy link
Contributor

@berinhard berinhard commented Sep 17, 2021

This PR introduces a new app named mailing to hold all the code related to DB stored emails' notification templates. This app also exposes base classes to extend its usage within django admin and forms.

The sponsors app now has a new model to define notifications that should be sent to sponsors. To send them, the user can access the Sponsorship list admin, filter and select the ones which have the EmailTargetable benefit feature to send the desired notification.

TODO:

  • render the email subject/message using the sponsorship data
  • send the email
  • preview the email before sending

@berinhard berinhard force-pushed the feature/sponsor-email-notification branch from dd943bd to 91839e1 Compare September 22, 2021 15:49
@berinhard berinhard marked this pull request as ready for review September 22, 2021 15:53
@berinhard berinhard requested a review from ewdurbin September 22, 2021 15:53
@berinhard
Copy link
Contributor Author

@ewdurbin this PR now has all the other feature we've discussed during our last meeting. The only thing missing is the preview part of the it. I still have to figure our how to implement this, but the great part of the email dispatch work is done and can be reviewed.

@berinhard
Copy link
Contributor Author

Now this PR also includes the preview step

@ewdurbin ewdurbin merged commit f99aa6d into main Oct 7, 2021
@ewdurbin ewdurbin deleted the feature/sponsor-email-notification branch October 7, 2021 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants