-
Notifications
You must be signed in to change notification settings - Fork 623
Enable PSF staff to force a required image from a sponsorship via benefit configuration #1900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewdurbin
reviewed
Oct 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The modeling looks sound, assuming that the actual relations to Sponsor
/Sponsorship
objects will be handled in views/controllers.
898f30a
to
1723de4
Compare
1723de4
to
129d2ed
Compare
Django polymorphic does not work with non-integer ids
64cde46
to
30a8672
Compare
…orm" This reverts commit 30a8672.
ewdurbin
approved these changes
Nov 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!!! THIS IS WIP !!!
This PR has a few commits from #1897, but once it gets merged, only the commits to address the custom assets will be displayed.
I'm opening this PR to get feedbacks from @ewdurbin on the DB modeling. Here's how I though about how to support generic assets under the sponsorship app:
internal_name
and arelated_to
choice field (sponsors / sponsorship). Both fields will be controlled to know to which object the asset should relate to and also to query over Generic FKs using theinternal_name
to check if the sponsor and/or sponsorship has the required asset;internal_name
andrelated_to
object to fetch for the stored data in our DB via a more generic model;I was thinking on following a very similar strategy with the documents assets (docx, pdf, ppts etc). We could define a new
RequiredDocumentAsset
configuration/benefit following the same strategy and using a newGenericFileAsset
class to store the uploaded document.