-
Notifications
You must be signed in to change notification settings - Fork 623
Fixed Issue#2190 | Homepage code syntax error #2191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Issue#2190 | Homepage code syntax error #2191
Conversation
Hi, |
FYI: I noticed that the next line of code in the example also has an extra backslash. name = input('What is your name?\\n') ...it should be this... name = input('What is your name?\n') |
>>> print("Hello, I'm Python!") | ||
<span class=\"output\">Hello, I'm Python!</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ewdurbin apologies to ping directly, but I thought that this might be worth a quick fixup. It relates to a syntax error in one of the @eshaanmandal's fix should work as-is. I've added a suggestion that we could additionally use unicode in the example code (to match an existing comment), but I could move my suggestion into a separate follow-up pull request. (also a quick deployment note/reminder: as you discovered before, these examples are fixture data that are loaded into the db to take effect) |
@ewdurbin ek, sorry - a nitpick about this: although the code syntax for this sample has been fixed on the homepage, some of HTML escaping may have gone a bit wonky, and that results in all of the text appearing in green (instead of a mixture of syntax highlighting colours, as with the other samples) Expected syntax highlighting in HTMLHTML snippet<span class="comment"># Python 3: Simple arithmetic</span> Appearance of code sample fiveHTML snippet<span class="\"comment\""># Simple output (with Unicode)</span> (some kind of HTML-escaping issue?) |
Fixed issue #2190. Website home page, in the code example 5(Quick & Easy to Learn) has SyntaxError in first line at https://www.python.org/