Using `mock.patch` as a decorator doesn't properly forward the underlying function signature (even with a `new=` argument) #10324

bluenote10 · 2023-06-16T08:28:03Z

The following seems to type check fine (both mypy and pyright) even though it should not (I would hope):

from unittest.mock import Mock, patch

@patch("sys.exit", new=Mock())
def f(i: int) -> None:
    ...

f("a")

Tried with types-mock==5.0.0.6.

The text was updated successfully, but these errors were encountered:

Fixes python#10324

Fixes #10324

hauntsaninja added a commit to hauntsaninja/typeshed that referenced this issue Jun 16, 2023

unittest.mock: use ParamSpec in patch

b85b238

Fixes python#10324

hauntsaninja mentioned this issue Jun 16, 2023

unittest.mock: use ParamSpec in patch #10325

Merged

srittau added the stubs: false negative Type checkers do not report an error, but should label Jun 16, 2023

srittau closed this as completed in #10325 Jun 20, 2023

srittau pushed a commit that referenced this issue Jun 20, 2023

unittest.mock: use ParamSpec in patch (#10325)

9e86c60

Fixes #10324

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Using `mock.patch` as a decorator doesn't properly forward the underlying function signature (even with a `new=` argument) #10324

Using `mock.patch` as a decorator doesn't properly forward the underlying function signature (even with a `new=` argument) #10324

bluenote10 commented Jun 16, 2023

Uh oh!

Using mock.patch as a decorator doesn't properly forward the underlying function signature (even with a new= argument) #10324

Using mock.patch as a decorator doesn't properly forward the underlying function signature (even with a new= argument) #10324

Comments

bluenote10 commented Jun 16, 2023

Using `mock.patch` as a decorator doesn't properly forward the underlying function signature (even with a `new=` argument) #10324

Using `mock.patch` as a decorator doesn't properly forward the underlying function signature (even with a `new=` argument) #10324