Skip to content

Replace isort with ruff? #10911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
srittau opened this issue Oct 18, 2023 · 1 comment · Fixed by #10912
Closed

Replace isort with ruff? #10911

srittau opened this issue Oct 18, 2023 · 1 comment · Fixed by #10912

Comments

@srittau
Copy link
Collaborator

srittau commented Oct 18, 2023

I think @AlexWaygood suggested this originally and I pushed back against it. I've come around to the idea to using ruff for sorting imports, iff ruff has feature parity with and same sort order as isort (for our use case).
@AlexWaygood
Copy link
Member

I'm +1 on this. isort isn't exactly bug-free, and has very infrequent releases (so bugs don't generally get fixed quickly). From what I can tell, ruff pretty much has feature parity with isort, has much more frequent releases, and is also faster. Plus, we're already using ruff in CI, so it'll be one less tool to have to worry about.

@Avasam Avasam mentioned this issue Oct 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replacing isort with Ruff Avasam/typeshed
2 participants
@srittau @AlexWaygood