Skip to content

Stubs for Greenlet #9493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Avasam opened this issue Jan 11, 2023 · 4 comments
Closed

Stubs for Greenlet #9493

Avasam opened this issue Jan 11, 2023 · 4 comments
Labels
stubs: request OUTDATED! Request to add stubs for a new package to typeshed

Comments

@Avasam
Copy link
Collaborator

Avasam commented Jan 11, 2023 •
edited
Loading

Greenlet is not typed and will require stubs for #9491
The maintainer(s) "currently have no desire to try to maintain any typing information": python-greenlet/greenlet#244)
@hauntsaninja hauntsaninja added the stubs: request OUTDATED! Request to add stubs for a new package to typeshed label Jan 11, 2023
@Avasam
Copy link
Collaborator Author

Avasam commented Jan 11, 2023 •
edited
Loading

Alternatively, if you consider sqlalchemy.util._concurrency_py3k.py__AsyncIoGreenlet to be implementation details. Then a stub won't be needed.

@AlexWaygood
Copy link
Member

Alternatively, if you consider sqlalchemy.util._concurrency_py3k.py__AsyncIoGreenlet to be implementation details. Then a stub won't be needed.

It looks pretty implementation detail-y to me :)

Having said that, greenlet is quite a widely used package. Other people might also benefit from greenlet stubs. Up to you whether you think it's worth the effort or not!

@Avasam
Copy link
Collaborator Author

Avasam commented Jan 11, 2023

Up to you whether you think it's worth the effort or not!

I'll leave this issue open (there's an existing need for this stub). But I'm probably gonna skip on being the one to add it for the time being :P

@AlexWaygood
Copy link
Member

AlexWaygood commented Jan 11, 2023 •
edited
Loading

I'll leave this issue open

Our general policy is to close issues like this, since there's not really anything actionable for the maintainers, and issues like this tend to accumulate and grow stale pretty quickly if we don't close them 😉

For anybody else reading this: feel free to contribute stubs for greenlet at any time! PRs are always welcome at typeshed 😀

@AlexWaygood AlexWaygood closed this as not planned Won't fix, can't repro, duplicate, stale Jan 11, 2023
@Avasam Avasam mentioned this issue Jan 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stubs: request OUTDATED! Request to add stubs for a new package to typeshed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Avasam @hauntsaninja @AlexWaygood